Split toolchain.py into separate modules#526
Merged
Merged
Conversation
inclement
force-pushed
the
split_toolchain
branch
from
9971d63 to
44a0e99
Compare
Member
Author
|
@kived I've split it up as seemed sensible - toolchain.py remains the entry point, build.py contains most of the building stuff, and mostly each of the other class types is split up into its own module. Does it look okay to you? (A few things remain to be done, like making each recipe import from the right submodule rather than via toolchain) |
Contributor
|
Looks good to me! 👍 |
Member
Author
|
Great. I noticed a couple of small bugs today, but I'll fix them and merge later tonight. |
Provides backwards compatibility for recipes.
Contributor
|
I fixed a bug with imports in the pygame recipe by importing them in toolchain.py (debug and ensure_dir). |
add missing code from previous pr
…into split_toolchain
inclement
added a commit
that referenced
this pull request
Dec 11, 2015
Split toolchain.py into separate modules
Member
Author
|
Thanks, I don't know how I missed that previous PR. Looks good now though so I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP, do not merge yet!
Opinions welcome, I'm not certain about the best way to make some of the splitting choices.